[Improve][Pom] Add junit4 to the root pom #5611

Carl-Zhou-CN · 2023-10-11T03:44:10Z

1.Add junit4 to the root pom，pecification version of junit4

If any new Jar binary package adding in your PR, please add License Notice according
New License Guide
If necessary, please update the documentation to describe the new feature. https://github.com/apache/seatunnel/tree/dev/docs
If you are contributing the connector code, please check that the following files are updated:
1. Update change log that in connector document. For more details you can refer to connector-v2
2. Update plugin-mapping.properties and add new connector information in it
3. Update the pom file of seatunnel-dist
Update the release-note.

Hisoka-X · 2023-10-12T03:09:45Z

Just in my mind, can we remove junit4 in the repository?

Carl-Zhou-CN · 2023-10-12T07:12:10Z

EricJoy2048 · 2023-10-19T06:46:50Z

Just in my mind, can we remove junit4 in the repository?

The use of testcontainer must rely on junit4. So junit4 can not remove.

zhouyao and others added 2 commits October 11, 2023 11:41

[Improve][Pom] Add junit4 to the root pom

a3c8e28

Merge branch 'apache:dev' into junit

0176eec

Merge branch 'apache:dev' into junit

0dec0d6

Merge branch 'apache:dev' into junit

f633745

EricJoy2048 approved these changes Oct 19, 2023

View reviewed changes

github-actions bot added approved reviewed labels Oct 19, 2023

ic4y approved these changes Oct 19, 2023

View reviewed changes

EricJoy2048 merged commit 7b4f7db into apache:dev Oct 19, 2023

Provide feedback